Closed hakan458 closed 4 months ago
Attention: Patch coverage is 0%
with 21 lines
in your changes missing coverage. Please review.
Project coverage is 43.73%. Comparing base (
a20ead5
) to head (9c0f058
). Report is 20 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
server/tasks/process_file.py | 0.00% | 15 Missing :warning: |
server/app.py | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We observed an issue where the list of kafka topics was growing on develop Adala instance, even though we implemented logic to delete them after completing a job. However, we did not handle the case of a job failing, or being canceled. I have added a handler to be run when the parent_streaming_task fails, so that we clean up topics, and also cleaning up topics when we cancel a job.
Also added logic to attempt to stop input/output jobs when the parent task fails.