HumanSignal / label-studio-frontend

Data labeling react app that is backend agnostic and can be embedded into your applications — distributed as an NPM package
https://labelstud.io/
Apache License 2.0
421 stars 316 forks source link

fix: LEAP-89: Fix rendering of relation arrow in MIG case #1631

Closed Gondragos closed 11 months ago

Gondragos commented 11 months ago

PR fulfills these requirements

Change has impacts in these area(s)

(check all that apply)

Describe the reason for change

In the case of Image Segmentation with Image tag being in gallery mode a relation arrow may not follow the regions on switching between images.

What does this fix?

It adds an directive for relation to observe current image index to initiate rendering of an arrow on switching between images.

What libraries were added/updated?

N/A

Does this change affect performance?

Nope

Does this change affect security?

Nope

What alternative approaches were there?

N/A

What feature flags were used to cover this change?

N/A

Does this PR introduce a breaking change?

(check only one)

What level of testing was included in the change?

(check all that apply)

Which logical domain(s) does this change affect?

Image Segmentation, Image, Relations, Gallery

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bee2622) 68.28% compared to head (b4ebb3d) 68.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1631 +/- ## ======================================= Coverage 68.28% 68.28% ======================================= Files 443 443 Lines 28687 28687 Branches 7629 7629 ======================================= + Hits 19589 19590 +1 + Misses 7846 7845 -1 Partials 1252 1252 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.