HumanSignal / label-studio-frontend

Data labeling react app that is backend agnostic and can be embedded into your applications — distributed as an NPM package
https://labelstud.io/
Apache License 2.0
421 stars 316 forks source link

fix: LEAP-368: Don't add `hidden` and `locked` to undo history #1641

Closed hlomzik closed 11 months ago

hlomzik commented 11 months ago

Very simple fix. But there is a new UX problem them: if you undo/redo actions done to hidden regions you see no changes on the screen, previously region became visible at some point and only then undo went through actual actions.

PR fulfills these requirements

What feature flags were used to cover this change?

none — maybe we need this to cover UX change

What alternative approaches were there?

This change affects (describe how if yes)

Does this PR introduce a breaking change?

What level of testing was included in the change?

hlomzik commented 11 months ago

/git merge master

Workflow run Successfully pushed new changes: Merge remote-tracking branch 'origin/master' into fb-leap-368/undo-hidden (6b538578932187330553625d4136227f1a9a69fd)

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c7243d) 68.28% compared to head (2cd8070) 64.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1641 +/- ## ========================================== - Coverage 68.28% 64.54% -3.75% ========================================== Files 443 443 Lines 28690 28690 Branches 7630 7519 -111 ========================================== - Hits 19591 18517 -1074 - Misses 7847 10173 +2326 + Partials 1252 0 -1252 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.