Closed hlomzik closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1a234f1
) 68.79% compared to head (81dcb7c
) 21.93%. Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
New validation system (#1649) started to invoke
validateValue()
from control tags, but Textarea had a different meaning for this method, validating only text just entered by user, so the format was different from the whole Textarea result and LSF was crashing. Also semantics is also different, so the method was simply renamed to not clash with new validation.PR fulfills these requirements
Describe the reason for change
LSF crashes on submit with
Textarea
tag with bothrequired
andskipDuplicates
set to true.What feature flags were used to cover this change?
skipDuplicates
work only withfflag_feat_front_lsdv_4659_skipduplicates_060323_short
ONWhat alternative approaches were there?
To validate duplicated texts on submit as well, but that can block some existing annotations and should be done separately as a feature.
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?