search

HumanSignal / label-studio

Label Studio is a multi-type data labeling and annotation tool with standardized output format
https://labelstud.io
Apache License 2.0
19.4k stars 2.41k forks source link

Zooming on Small Images Should Fill Available Space #1622

Open dsanders11 opened 3 years ago

dsanders11 commented 3 years ago

Is your feature request related to a problem? Please describe.

Zooming in on small pictures for more accurate labeling is made less useful by the fact that the original image size limits the size of the zoomed in area. With a fullscreen browser window I have lots of extra space, but when I zoom in on a small image I'm stuck looking at the zoomed in section through a frustratingly small area, requiring panning to move around, when there's plenty of space in the window to show the larger image.

Describe the solution you'd like Zooming in on an image should increase the size of the image in the window as well, filling available space.

makseq commented 3 years ago

@dsanders11 Please, check the solution from this issue: https://github.com/heartexlabs/label-studio/issues/1229

makseq commented 3 years ago

However, it's better to have a more native way to do it.

dsanders11 commented 3 years ago

@makseq, thanks for the response and the link to the other issue. However, that doesn't really doesn't address my issue. It looks like that allows me to manually make the images larger, but it doesn't fix the zooming issue. I have images of greatly varying sizes, setting a fixed width isn't an optimal experience.

In my opinion, zooming in should expand the image dimensions in the viewer to match those of the zoomed image, up until maxWidth. So if it's a 100px by 200px image, and I zoom in 2x, it should be rendering as 200px by 400px. Instead I currently have to look at the 200px by 400px image through a 100px by 200px window.

makseq commented 3 years ago

@dsanders11 I hope I understood you correctly, but could you also attach some screenshots please demonstrating this problem?

dsanders11 commented 3 years ago

@makseq, sure, here's what I mean in screen shots, roughly.

Here's an image for labeling, 100px by 100px, not zoomed in:

NotZoomed

Here's what happens when I zoom in a good amount. I have to pan so that I can see the corner, since the image size is still only 100px by 100px in the view.

ZoomedIn

Here's what I'd like to happen when I zoom in, since there's plenty of available space to show the zoomed in image in its entirety:

ZoomedInExpected

greyeagle commented 2 years ago

Just came upon this request. Even I could work with the solution in #1229 I'd like to upvote being able to zoom the way described in the screenshots and this request. I's more natural in my opinion.