feat: DIA-1627: Add label/tag in LD to identify SC users and set up LD Rule for SC users in Prompts FF

matt-bernstein commented 1 week ago

Allow LSE to override the user_dict sent to LD with information about Starter Cloud

PR fulfills these requirements

[ ] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[ ] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

[ ] Product design
[ ] Backend (Database)
[ ] Backend (API)
[ ] Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[ ] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

sentry-io[bot] commented 1 week ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/core/feature_flags/base.py

Function	Unhandled Issue
`_get_user_repr`	AttributeError: 'NoneType' object has no attribute 'email' /p... `Event Count:` 1

_{Did you find this useful? React with a 👍 or 👎}

netlify[bot] commented 1 week ago

Deploy Preview for label-studio-docs-new-theme canceled.

Name	Link
Latest commit	e1ddc441a5d45fa39f6435ed99011e2d64a8081f
Latest deploy log	https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/673c2587ec0afb0008571812

netlify[bot] commented 1 week ago

Deploy Preview for heartex-docs canceled.

Name	Link
Latest commit	e1ddc441a5d45fa39f6435ed99011e2d64a8081f
Latest deploy log	https://app.netlify.com/sites/heartex-docs/deploys/673c25873b200f00086cdee7

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.76%. Comparing base (52aea5b) to head (e1ddc44). Report is 8 commits behind head on develop.

Files with missing lines	Patch %	Lines
label_studio/core/feature_flags/base.py	75.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #6677 +/- ## =========================================== - Coverage 76.77% 76.76% -0.02% =========================================== Files 169 169 Lines 13876 13882 +6 =========================================== + Hits 10653 10656 +3 - Misses 3223 3226 +3 ``` | [Flag](https://app.codecov.io/gh/HumanSignal/label-studio/pull/6677/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HumanSignal) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/HumanSignal/label-studio/pull/6677/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HumanSignal) | `76.76% <75.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HumanSignal#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

HumanSignal / label-studio