search

Humanizr / Humanizer

Humanizer meets all your .NET needs for manipulating and displaying strings, enums, dates, times, timespans, numbers and quantities
Other
8.6k stars 956 forks source link

Adding welsh (cy) support #1529

Open IeuanWalker opened 1 month ago

IeuanWalker commented 1 month ago

Hi, I've created a POC project for my workplace, and that piece of work is going ahead now. Our current app supports the Welsh language so looking to see if/ how I create a PR for it.

Currently, we only need support for DateTimeOffset.Humanize - image

So I'd like to do a PR to add support for that function, but would like to add support for all the features.

Some background, I work for Cardiff city, which is the capital of Wales and the Welsh language. We have our own in-house translation team for Welsh language

hangy commented 1 month ago

I believe every language support is highly welcome! 👍🏻 Generally, it's not a problem to start with one feature for a language and to add others gradually. It looks like DateTimeOffset.Humanize is mostly based off of resource files, but unit tests to ensure that everything works as expected would be necessary. #924 looks like a good sample of adding support for a new culture.

IeuanWalker commented 3 weeks ago

thanks @hangy, i've created a PR, would you know the answers to the questions i left in a comment on there?