search

Humanizr / Humanizer

Humanizer meets all your .NET needs for manipulating and displaying strings, enums, dates, times, timespans, numbers and quantities
Other
8.7k stars 965 forks source link

TimeOnly.ToClockNotation with german culture returns english like time #1532

Open RenNagasaki opened 3 months ago

RenNagasaki commented 3 months ago

If you use .ToClockNotation on a TimeOnly object created with german culture it still returns the english time definition.

Like: 08:30 becomes "half past acht". (The number is correctly translated but not the description of the time) It should be either: "halb neun" or "acht uhr dreißig". This goes for all variants of time. :45/:15

Using it with a time like: 8:37 returns "acht siebenunddreißig" but should be "acht uhr siebenunddreißig". grafik

I hope I made clear what I mean.

Kind regards, Ren

hangy commented 3 months ago

True, this extension is currently only implemented for a handful of languages: https://github.com/Humanizr/Humanizer/blob/1dee67d72d53282aff76be8a2aaacc4a28ea6cbf/src/Humanizer/Configuration/TimeOnlyToClockNotationConvertersRegistry.cs#L8-L14