Here is a checklist you should tick through before submitting a pull request:
[X] Implementation is clean
[X] Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
[X] No Code Analysis warnings
[X] There is proper unit test coverage
[X] If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
[X] There are very few or no comments (because comments shouldn't be needed if you write clean code)
[X] Xml documentation is added/updated for the addition/change
[X] Your PR is (re)based on top of the latest commits from the main branch (more info below)
[X] Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
[X] Readme is updated if you change an existing feature or add a new one
[X] Run either build.cmd or build.ps1 and ensure there are no test failures
Here is a checklist you should tick through before submitting a pull request:
mainbranch (more info below)fixes #<the issue number>build.cmdorbuild.ps1and ensure there are no test failuresfixes #1241