search

Humans-of-Julia / HoJBot.jl

Yay, our own Discord bot!
MIT License
22 stars 11 forks source link

introduce PluginBase #90

Closed rapus95 closed 3 years ago

tk3369 commented 3 years ago

I guess you can get this in as part of #91. Close this one?

rapus95 commented 3 years ago

@tk3369 you mean by merging unrelated topics into the same PR? 🙈 sure. The reason why it's also part of the other PR is because I rebased them on top of each other to have a streamlined merge process. But the can be pushed mostly independently nevertheless (by rebasing again) But i see where that comes from 🤔 Then I need a more generic PR name for the other one

tk3369 commented 3 years ago

Yes, my perspective is that it is not easy to review a framework without an actual use case. So I'm fine with bundling it with the very first usage of that framework.