Fix hit plugin with stacked lines

[cesutherland]

Thanks for the changes! Relates to #136.

One quick note then it should be good to merge.

[cesutherland]

@ioguix could you take a look at the comments here? I'll pull in your fixes.

-Carl

[ioguix]

@cesutherland: I just added a new commit to remove forgotten comments and use a specific member for the stack offset in the array.

I was not aware the third value of this array could be used by users for some other things. I am not really comfortable with this solution because it mixes arrays and object. Actually, I wonder if it forces javascript to transform the array (x, y, o) in an array of object or something...Why not using an official "properties" object in the 3rd value of the object like that:

data[i][2] = { 
    // some user properties...
    tooltip: "blah",
    stackOffset: stack1
}

I don't know if my comment worth the pain it can causes to other users though. Feel free to pull the code as-is or keep discussing my comment.

[ioguix]

I've found my answer about what's going on with using "data[i].y0", see:

• http://stackoverflow.com/questions/874205/what-is-the-difference-between-an-array-and-an-object
• http://andrewdupont.net/2006/05/18/javascript-associative-arrays-considered-harmful/

So the array is not transformed to an object, but it is not that clean neither. But I can leave with that if the solution would breaks tons of code out there.

Cheers,

[cesutherland]

Thanks for looking more into it! Arrays are indeed objects.

I believe this the solution most likely to cause the least harm. The issue with the 3rd value is that some chart types have more than 2 dimensions (OHLC, bubble, etc.) which do use data[2]. A user may wish to use that same data in multiple chart types.

[ioguix]

Oh, ok, that make sense then.

Anything else to consider on this issue before pulling it ?

[cesutherland]

Just that we were in sync on it!