Polluting global namespace with `bean` and `_`

HumbleSoftware / Flotr2

Graphs and Charts for Canvas in JavaScript.

http://www.humblesoftware.com/flotr2/

MIT License

2.45k stars 528 forks source link

Polluting global namespace with `bean` and `_` #257

Open jasonkarns opened 10 years ago

jasonkarns commented 10 years ago

Flotr is pulling in libraries and not properly enclosing them in a closure so they are conflicting with the global namespace.

jasonkarns commented 10 years ago

This is tangentially related to #225. (Using the no-lib build is a workaround.) However, the full build ought to be pulling in the dependencies from within a closure. Benefits:

Flotr can control the version(s) of its dependencies
the full build is still self-contained (end users don't need to deal with the dependency management)
only the Flotr API is exposed to the global namespace

cesutherland commented 10 years ago

I don't disagree.

For anyone with more sophisticated packaging requirements, the no-lib build is the way to go.