Closed dvoyni closed 10 years ago
Thanks for the PR! Are you able to execute the test suite?
Hey! I've added the examples required. Unfortunately I have no configured environment to execute test suite. I still can do it if you provide me some instructions.
All merged in, thanks for the contribution! The tooling for this project is a little dated, but here are the basic instructions for testing:
https://github.com/HumbleSoftware/Flotr2#development
It's all in the make file as well.
Basically, when making changes tests are run against a 'stable' or 'known working' copy of flotr2. If changes break any of the existing chart implementations, they will show up in the spec runner as regressions. To add new features, it is required to build a new stable reference otherwise the tests fail. I take care of that myself :-)
Thanks for the contribution!
Implementer financial bar chart.