search

HumbleSoftware / js-imagediff

JavaScript / Canvas based image diff utility with Jasmine matchers for testing canvas.
http://humblesoftware.github.com/js-imagediff/
MIT License
788 stars 99 forks source link

Included workaround for error 'Image given has not completed loading'... #39

Closed Brootux closed 10 years ago

Brootux commented 10 years ago

... of canvas-library. The error was happening when working with lots of images to compare.

Found workaround here: Automattic/node-canvas#254

Comparing now works for me. Hope this helps anybody.

cburgmer commented 10 years ago

Thanks. Also see #17, #31 and #35.

Brootux commented 10 years ago

Ill never tried this via comandline. Im using the node-module "grunt-screenshot-compare" wich uses "automated-screenshot-diff" wich in the end uses "js-imagediff".

I have no ressources to check if this solves all other use-cases, so maybe we should wait until other people patched their js-imagediff and give a positive response?

cesutherland commented 10 years ago

In the cases where the "Image given has not completed loading" the image data will be computed and returned before the image has been drawn.

cesutherland commented 10 years ago

This should be all sorted with the merge of #31