HumbleUI / JWM

Cross-platform window management and OS integration library for Java
Apache License 2.0
561 stars 44 forks source link

add setIcon function for Windows #126

Closed i10416 closed 3 years ago

i10416 commented 3 years ago

I'm adding setIcon function for Windows.

i10416 commented 3 years ago

jfx

i10416 commented 3 years ago

https://github.com/rust-windowing/winit/blob/master/src/platform_impl/windows/icon.rs

tonsky commented 3 years ago

Let’s postpone “set icon by bytes” to another PR. I’m not sure we want to bring bitmaps and encoder/decoder to the codebase. Loading from file should be enough for now.

Can you please resolve current conflicts and add dummy setIcon implementations for WindowX11.java and WindowMac.java? Just simple

@Override
public Window setIcon(File path) {
  // TODO #95
  return this;
}

So that they continue to compile? Thanks!

tonsky commented 3 years ago

And thank you for your contribution, that’s pretty substantial and an imporant feature.

i10416 commented 3 years ago

Thank you for reviewing and I fixed conflicts.

tonsky commented 3 years ago

Awesome, merged! Thank you