More macOS titlebar changes

HumbleUI / JWM

Cross-platform window management and OS integration library for Java

Apache License 2.0

571 stars 46 forks source link

More macOS titlebar changes #184

Closed mworzala closed 2 years ago

mworzala commented 2 years ago

Makes the following changes:

Do not actually remove the title from the NSWindow, instead hide the title, traffic lights, and set full size content view
Add WindowMac#setTitleVisible(boolean)

Seeing an issue with setTitlebarVisible currently, and waiting on a way to hide traffic lights from #183

tonsky commented 2 years ago

I will probably postpone #183 to way later since it’s not that high of the priority. If you can just hide traffic lights really quick without changing their position, just go ahead, I don’t want to be a blocker

mworzala commented 2 years ago

I added a temporary way to toggle the traffic lights. I am unsure what is going on with the drawing rect. When setting full size content view the titlebar goes away, but the content is not shifted up to fill the gap until you resize the window manually. Then it seems to work from then on out. eg. CMD-T and note the gap at the top, then resize and it is fixed. The issue appears on main as well, but it's less obvious (It happens in the Transparent setting).

tonsky commented 2 years ago

I suggest we focus on creating new windows, not switching styles on existing one. I think it’s a more realistic use-case (you usually know what type of window you want, instead of deciding on the fly).

For that use-case this PR seems to work good, so let’s merge it.