search

HumbleUI / Skija

Java bindings for Skia
Apache License 2.0
498 stars 34 forks source link

Exclude some useless jars when publishing GitHub Release #46

Closed Glavo closed 1 year ago

Glavo commented 1 year ago

This PR removes the javadoc and sources jar of the platform jar -- because they are useless empty jars, but retains the ssources and javadoc of shared jar in GitHub Release.

I try to filter them by adjusting the files parameter of action-gh-release, but I don't know why it doesn't work, so I use rm to implement this function.

tonsky commented 1 year ago

Yes! I forgot that those are empty for native code jars

tonsky commented 1 year ago

Actually... turns out they were required to publish to maven central :) ac0b4c7c6928fd789130ed4cc5f2c82ab5d9f5ee

Glavo commented 1 year ago

Actually... turns out they were required to publish to maven central :) ac0b4c7

I know, so I only deleted these files after publishing them to Maven Central. Am I missing something?

tonsky commented 1 year ago

Yeah, you are right, of course. I spent entire day yesterday trying to get 0.116.0 out, got tired in the end and blamed everything :( 085e35f0226234aab4732bb0cf5ca9b1eafac5c8