SVGNode Attribute Getters and Setters

HumbleUI / Skija

Java bindings for Skia

Apache License 2.0

514 stars 34 forks source link

SVGNode Attribute Getters and Setters #70

Open wilgaboury opened 2 months ago

wilgaboury commented 2 months ago

Bindings for the assorted attribute getters and setters on SkSVGNode.

wilgaboury commented 2 months ago

Wanted to put this pull request up for some initial review and feedback. I'm also planning to give it a thorough self-review this week and will likely make some small changes.

tonsky commented 2 months ago

Sorry, a bit busy, will look at it next week

wilgaboury commented 2 months ago

No worries! I know it's a big change to submit all at once, so please don't feel like you have to rush to review it.

tonsky commented 1 month ago

Looks great to me, would be happy to have it. How about having a Scene demonstrating some of these new APIs? Maybe not all, but just a few?

wilgaboury commented 1 month ago

Sounds good, I'll add a scene later this week.

tonsky commented 1 month ago

From quick overview, I would love to see:

Use of currentColor, and passing it from outer world (e.g. SVG that uses currentColor, and we change it on hover from the scene)
Modifying some attribute inside SVG dynamically (also on hover?)

wilgaboury commented 1 month ago

Right now, I don't think it's possible to pass in currentColor from the outer world. I would have to add additional bindings for SkSVGRenderContext and the specific method SkSVGDOM.renderNode (which I would like to do but is going to take more time).

That being said I've messed around with dynamically changing the root nodes fill color (which is inherited by the rest of the SVG) and making a scene that changes it on hover should be easy.

tonsky commented 1 month ago

Yeah let’s do that. The idea is to demonstrate/test what is available