Humblemonk / DiceMaiden

Dice bot for Discord
Apache License 2.0
121 stars 56 forks source link

Rolling Through DMs Gives Last Character (globally) Rolled as Name #211

Closed KiriKaz closed 1 year ago

KiriKaz commented 1 year ago

Description of bug When using a roll command with Dice Maiden in the DMs, it rolls normally, but the character/person's name is replaced with the last roll the bot gave for anyone using the bot in a server, leading to some potentially awkward surprises.

To Reproduce

  1. Open DM with Dice Maiden.
  2. Roll any valid roll. Used in the example is 2d20.
  3. Observe the error message. Your name is replaced with the last user who rolled with the bot in a server.
  4. If you roll again, you may observe the same name, or it will be replaced with whoever most recently rolled the bot in a server.

Expected behavior Dice Maiden should use my username when rolling in DMs.

Screenshots

image image

Additional context Further rerolls do not replace the username.

Humblemonk commented 1 year ago

Well thats an unfortunate new one. Ill take a look at this today

Humblemonk commented 1 year ago

Resolved here c888eab796a82e89b46513f6d0120f7cb4d19f3d

KiriKaz commented 1 year ago

Looks like there's a typo in your commit, beyond that, looks good! Thanks for fixing it.