Humblemonk / DiceMaiden

Dice bot for Discord
Apache License 2.0
125 stars 56 forks source link

rolls do not succeed if the comment contains the word "kidneys" #90

Closed thatandromeda closed 4 years ago

thatandromeda commented 4 years ago

Describe the bug In a gaming session, we found that the following command did not result in dice being rolled: !roll 2d10+3 !I like my kidneys

However, !roll 2d10+3 !I like my liver worked fine.

Other attempts with the word 'kidneys' also failed. (e,g, !roll 1d6 !kidneys, !roll 2d10+2 !Spray their kidneys!)

To Reproduce Go to a Discord room with DiceMaiden. Type one of the above commands. Nothing happens.

Expected behavior I expect to see the results of the die roll.

Additional context After some rephrasing, the paladin in question protected his internal organs with a full success.

Chuckaluphagus commented 4 years ago

Can confirm.

Humblemonk commented 4 years ago

Ok this is a pretty funny bug. Thanks for letting us know! We will look into it

Humblemonk commented 4 years ago

Already found the issue. Issue will be resolved within the hour.

thatandromeda commented 4 years ago

Amazing, thanks!

gatherer818 commented 4 years ago

I really want to know what was causing this problem. If you remember, can you say?

ShadowGamer3 commented 4 years ago

Holy crap! What a bug... now I’m curious! What was causing it?

Humblemonk commented 4 years ago

The wrath and glory game system check for "difficulty number" was incorrectly checking comments. Any comment with the characters "dn" in it were causing the bot to error out.

gatherer818 commented 4 years ago

Ah, the "magic combination of letters", that makes sense. Thanks for taking the time to satisfy our idle curiosity <3