Log network errors instead of crashing silently, fix logging configuration

Hundemeier / sacn

A simple ANSI E1.31 (aka sACN) module for python.

MIT License

47 stars 21 forks source link

Log network errors instead of crashing silently, fix logging configuration #18

Closed mje-nz closed 4 years ago

mje-nz commented 4 years ago

Not sure what the ideal behaviour is when there's a socket error in the output thread; in master the thread dies with no way to recover, this PR makes it log and continue.

I've also updated the logging statements to use the namespace set up in init instead of the root logger.

Hundemeier commented 4 years ago

Thank you for this pull request! Both ideas are great and since I see no obvious errors I will merge it.

mje-nz commented 4 years ago

Thanks for the quick release!