Closed CrazyIvan359 closed 4 years ago
Thanks for your pull-request!
There seems to be a merge conflict (see send_out_all_universes
in output_thread.py
). Could your resolve it?
One nitpick: Could you add a sentence in the docstring of the flush
method about the exception that might be thrown?
I thought that might happen because my other PR also added an argument to send_out_all_universes
. I will rebase when I get home from work.
Adding a note about that is a good idea, I should have added that.
All set now! All checks have passed and there are no conflicts.
This adds the ability to send a subset of the activated universes when calling
sACNsender.flush
, if not provided it will send all active universes like it did before.