Allow flushing a custom subset of universes

Hundemeier / sacn

A simple ANSI E1.31 (aka sACN) module for python.

MIT License

47 stars 21 forks source link

Allow flushing a custom subset of universes #22

Closed CrazyIvan359 closed 3 years ago

CrazyIvan359 commented 3 years ago

This adds the ability to send a subset of the activated universes when calling sACNsender.flush, if not provided it will send all active universes like it did before.

Hundemeier commented 3 years ago

Thanks for your pull-request! There seems to be a merge conflict (see send_out_all_universes in output_thread.py). Could your resolve it?

One nitpick: Could you add a sentence in the docstring of the flush method about the exception that might be thrown?

CrazyIvan359 commented 3 years ago

I thought that might happen because my other PR also added an argument to send_out_all_universes. I will rebase when I get home from work.

Adding a note about that is a good idea, I should have added that.

CrazyIvan359 commented 3 years ago

All set now! All checks have passed and there are no conflicts.