search

Hundemeier / sacn

A simple ANSI E1.31 (aka sACN) module for python.
MIT License
47 stars 21 forks source link

Data packet test #29

Closed mthespian closed 3 years ago

mthespian commented 3 years ago

Begin data_packet tests

Fix retrieving universe nums > 255 from packet Move encode of ushort to function within root_layer Remove restriction to 0x00 start code, other start codes can be valid Received source names now come out as a string

Hundemeier commented 3 years ago

There seems to be a merge conflict, you might need to rebase or merge the master into your current branch.

Other than that, I approve of the changes when the conflict is sorted out.

And maybe something minor for the future: if you want to include changes because of the linter, you can put them into a separate pull request. Then I can quickly merge that without any review. I don't mind linter warnings in a pull request that includes feature changes (like this one).

mthespian commented 3 years ago

It should be all current now!