Hundemeier / sacn

A simple ANSI E1.31 (aka sACN) module for python.
MIT License
48 stars 21 forks source link

Per Address Priorities #46

Open pleibold opened 7 months ago

pleibold commented 7 months ago

Excellent library, thank you for creating it. I'm seeing an issue where when I have a per address priority in the system, the library interprets the priority as the value for the address. In wireshark, the packets look essentially the same except for the the 0xdd designation of the type of packet (compared to a 0x00 as a level packet. I found some useful information here: https://support.etcconnect.com/ETC/Networking/General/Troubleshooting_sACN_priority_using_Wireshark

Any solves for this? Thanks!

Hundemeier commented 7 months ago

Sorry for the late reply: During thinking about your issue I am not totally sure if you simply spotted a "bug" in my Readme.md: the example for receiving DMX data was flawed. It interpreted packets with non-0x00 DMX start codes as DMX data, which is not correct in most cases. Please re-read the Readme about the receiving example, I changed two lines of code (these). Maybe applying something similar in your code fixes that problem?

Unfortunately for you, I consider the per-address-priorities to be out of scope for this library (as I stated in #26 on a similar matter). So if you want to use per-address-priorities properly, you should be able to implement per-address-priorites yourself (using the proprietary ETC spec) rather easily.

Feel free to reach out again, if your problem persist or you have other questions.

pleibold commented 7 months ago

Thank you, that's very helpful! I got it all working, and that section about the dmxStartCode solved it.