Dropping a network link with transmitting data is unrecoverable

Hundemeier / sacn

A simple ANSI E1.31 (aka sACN) module for python.

MIT License

47 stars 21 forks source link

Dropping a network link with transmitting data is unrecoverable #48

Closed andrewyager closed 3 months ago

andrewyager commented 3 months ago

We've just identified an issue when an sACN Node is directly connected to our transmitter.

In https://github.com/Hundemeier/sacn/blob/042968632deb914ed98b310762852778ace9994c/sacn/sending/sender_socket_udp.py#L96

the exception of being unable to transmit is caught, but never passed upstream to allow the code to be able to detect that the socket has been closed and take appropriate action (for instance, reconnect, or other).

Hundemeier commented 3 months ago

Good catch! This was not intended behavior and should have been handled similarly to https://github.com/Hundemeier/sacn/blob/1bc53abc677c97ba4f8a40e13b341de49ffd18c4/sacn/sending/sender_socket_udp.py#L37-L39

I've released v1.9.1 that fixes this bug.