search

HungryCatsStudio / circom-compat

Arkworks bindings to Circom's R1CS, for Groth16 Proof and Witness generation in Rust.
Apache License 2.0
0 stars 0 forks source link

Deprecate `circom` vs. `circom-2` distinction #5

Open mmagician opened 1 week ago

mmagician commented 1 week ago

Circom2 is already 2 years old, I don't think anyone is using the old repo, which itself has been deprecated: https://github.com/iden3/circom_old

I think we can safely remove the feature flag and just default to circom2 code.

jakehemmerle commented 1 week ago

Agreed.

Another thing, would we be able to come up with a plan to regenerate the circom2 test vectors with the latest circom repo? I worry there have been Wasm updates that affect the generated wasm blobs between now and then, but maybe this is a premature optimization.

mmagician commented 1 week ago

I was thinking the same. Ideally, we would have clear instructions on how to generate each of the test vectors. There are currently some circom files, some JSON etc., but it's unclear to me how they all related to each other.