Hunsu / gwt-graphics

Automatically exported from code.google.com/p/gwt-graphics
Apache License 2.0
0 stars 0 forks source link

SVGImpl's pop is wrong? #8

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
    public void pop(Element root, Element element) {
        root.appendChild(element);
    }

<< shouldn't that be root.removeChild?
using r16.

Original issue reported on code.google.com by andreas.chr.osowski on 4 Jun 2010 at 6:24

GoogleCodeExporter commented 8 years ago
Hi,

Do you have some problems with the DrawingArea.pop() or Group.pop() methods? Or 
why
do you think that appendChild is wrong method? 

The JavaDoc of appendChild says:

/**
   * Adds the node newChild to the end of the list of children of this node. If
   * the newChild is already in the tree, it is first removed.

Original comment by he...@kerola.net on 4 Jun 2010 at 6:30

GoogleCodeExporter commented 8 years ago
Hello.
Isn't the general Idea that pop() removes and returns the top element from the 
stack?
In the end, I had to use Group.remove() to properly remove the object. 

In general, I'd really like to see that classic pop function -> removing the 
head
element without any arguments.

-- 
Oh I'm sorry. I should have actually read the javadoc for vectorobjectcontainer.
After all, the functionality of pop() does indeed make some sense although I 
guess
that the function name isn't the best :)

So I guess that you could call this closed.

Original comment by andreas.chr.osowski on 5 Jun 2010 at 6:44

GoogleCodeExporter commented 8 years ago
Yes, you are right the function name could be better. If you have some ideas 
about
API improvements, please share your ideas in the discussion group:
http://groups.google.com/group/gwt-graphics

Original comment by he...@kerola.net on 5 Jun 2010 at 6:31

GoogleCodeExporter commented 8 years ago
I renamed the pop method to bringToFront in the 0.9.7 version.

Original comment by he...@kerola.net on 27 Jun 2010 at 10:49