master doesn't want to compile

[masagrator]

/mnt/d/Awoo-Installer-master/Awoo-Installer/include/Plutonium/Plutonium/Source/pu/pu_CFW.cpp: In function 'bool pu::IsReiNX()':
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/Plutonium/Plutonium/Source/pu/pu_CFW.cpp:20:9: error: 'SmServiceNam
' was not declared in this scope
         SmServiceName rnx = { "rnx" };
         ^~~~~~~~~~~~~
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/Plutonium/Plutonium/Source/pu/pu_CFW.cpp:20:9: note: suggested alternative: 'ViServiceType'
         SmServiceName rnx = { "rnx" };
         ^~~~~~~~~~~~~
         ViServiceType
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/Plutonium/Plutonium/Source/pu/pu_CFW.cpp:22:46: error: 'rnx' was not declared in this scope
         Result rc = smRegisterService(&tmph, rnx, false, 1);
                                              ^~~
/opt/devkitpro/devkitA64/base_rules:13: recipe for target 'pu_CFW.o' failed

As above - I'm lacking something or this code shouldn't be in master? :P

[Huntereb]

Are you on this version of libnx?

[masagrator]

Hmm... I was sure tham I am... But it looks like I wasn't... So I updated it, installed SDL2_mixer and SDL2_gfx and now I got this:

In file included from /mnt/d/Awoo-Installer-master/Awoo-Installer/source/sdInstall.cpp:29:
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/sdInstall.hpp:27:34: error: variable or field 'installNspFromFile' declared void
   27 |     void installNspFromFile(std::vector<std::filesystem::path> ourNspList, int whereToInstall);
      |                                  ^~~~~~
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/sdInstall.hpp:27:34: error: 'vector' is not a member of 'std'
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/sdInstall.hpp:1:1: note: 'std::vector' is defined in header '<vector>'; did you forget to '#include <vector>'?
  +++ |+#include <vector>
    1 | /*
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/sdInstall.hpp:27:62: error: expected primary-expression before '>' token
   27 |     void installNspFromFile(std::vector<std::filesystem::path> ourNspList, int whereToInstall);
      |                                                              ^
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/sdInstall.hpp:27:64: error: 'ourNspList' was not declared in this scope
   27 |     void installNspFromFile(std::vector<std::filesystem::path> ourNspList, int whereToInstall);
      |                                                                ^~~~~~~~~~
/mnt/d/Awoo-Installer-master/Awoo-Installer/include/sdInstall.hpp:27:76: error: expected primary-expression before 'int'
   27 |     void installNspFromFile(std::vector<std::filesystem::path> ourNspList, int whereToInstall);
      |                                                                            ^~~
/opt/devkitpro/devkitA64/base_rules:13: recipe for target 'sdInstall.o' failed
make[1]: *** [sdInstall.o] Error 1

[HookedBehemoth]

Do what the compiler tells you :P hunter forgot a #include

[Huntereb]

I'll fix this tonight. I guess I didn't do a clean build on master or something...

[Huntereb]

The vector header issue isn't a problem on my build server. The include is properly placed in the header file, and it should work for the source file as well.

[masagrator]

You forgot to add zstd as submodule to repo

Without it I got error that it lacks zstd.h After copying include folder files from zstd repo to your include it got past it until final compiling, when it shows this

/opt/devkitpro/devkitA64/lib/gcc/aarch64-none-elf/9.2.0/../../../../aarch64-none-elf/bin/ld: cannot find -lzstd
collect2: error: ld returned 1 exit status

Next time you should try to compile master on fresh instance of distro because servers can be too much distant from average environment :P Just dkp-pacman with all switch libs and build-essential

And something is wrong with compiling scheme. If something cancel compiling after this Awoo-Installer/source/sdInstall.cpp -o sdInstall.o

Then it goes back to it with next try without cleaning. But it shouldn't and it wastes time when many files got already compiled after this and everything goes away

[HookedBehemoth]

https://github.com/Huntereb/Awoo-Installer/issues/6#issuecomment-553113053

[HookedBehemoth]

Waiting for dkp...

[HookedBehemoth]

I added the vector include a few days ago. Idk how that ever worked for Hunter but I never doubted you...

[masagrator]

Ah, so there zstd is hiding... It would be nice to add info about it in visible place. :) It should now compiles correctly with this, but in next 2 weeks I won't check because of work, so I think issue can be closed.