search

HuobiRDCenter / huobi_Python

Python SDK for Huobi Spot API
https://huobiapi.github.io/docs/spot/v1/en
Apache License 2.0
682 stars 333 forks source link

Python3.9 compatible #85

Open pancak3 opened 3 years ago

pancak3 commented 3 years ago

json.loads removed arg encoding since python 3.9, see 'https://docs.python.org/3.9/library/json.html#json.loads'

Qumeric commented 3 years ago

I think

is_below_py39 = False
if sys.version_info.major < 3 and sys.version_info.minor < 9:
    is_below_py39 = True

Should be moved inside json_loads. Maybe import sys too.

Also, maybe encoding can be dropped even for Python 3.7 and 3.8?

pancak3 commented 3 years ago

I think

is_below_py39 = False
if sys.version_info.major < 3 and sys.version_info.minor < 9:
    is_below_py39 = True

Should be moved inside json_loads. Maybe import sys too.

Also, maybe encoding can be dropped even for Python 3.7 and 3.8?

I think

is_below_py39 = False
if sys.version_info.major < 3 and sys.version_info.minor < 9:
    is_below_py39 = True

Should be moved inside json_loads. Maybe import sys too.

Also, maybe encoding can be dropped even for Python 3.7 and 3.8?

Excellent advice! I am going to change it. Thanks!

kuznetsov-m commented 2 years ago

I have the same problem. @pancak3, thanks for this fix! Сould you please merge this PR?

pancak3 commented 2 years ago

I have the same problem. @pancak3, thanks for this fix! Сould you please merge this PR?

Haha this is really an old PR! I would like to help, but only authorized users are allowed to merge. Maybe you can try rebase in your local environment.

kuznetsov-m commented 2 years ago

I have the same problem. @pancak3, thanks for this fix! Сould you please merge this PR?

Haha this is really an old PR! I would like to help, but only authorized users are allowed to merge. Maybe you can try rebase in your local environment.

Yes, I merged the PR in my own repository. But I do not give up hope that an authorized user will merge this PR. I just didn't find a better user to mention in this PR 🙂

pancak3 commented 2 years ago

They did not maintain this for a long time. This branch may be merged decades later :D