search

HurricaneLabs / machinae

Machinae Security Intelligence Collector
MIT License
502 stars 99 forks source link

Provide indication of invalid site #44

Closed tcwaddell closed 6 years ago

tcwaddell commented 6 years ago

When an invalid site is specified with the '-s' argument, machinae does not give obvious feedback indicating that the site is invalid.

user@ubuntu:~$ machinae -s not_a_real_source A8EDE5B4E9AD5F52A3C28142FA26A4C2CAA2D9BD9E73AEAD41942D31986E4ABE
********************************************************************************
* Information for A8EDE5B4E9AD5F52A3C28142FA26A4C2CAA2D9BD9E73AEAD41942D31986E4ABE
* Observable type: hash.sha256 (Auto-detected: True)
********************************************************************************

user@ubuntu:~$
billford commented 6 years ago

Any preference for message that’s returned?

tcwaddell commented 6 years ago

I did not have anything specific in mind.

amg4110 commented 6 years ago

I think it should say something like:

Error: Invalid source! Please run "machinae --list-sites", pick your poison, and try again.

Or something along those lines. :D

billford commented 6 years ago

This entire thing made my eyes bleed. I will need to really really really dig in to make that work correctly and I have it somewhat worked out in a local branch. I added a message for now to check --list-sites if the results aren't what you expect.