search

Hurricos / realtek-poe

5 stars 10 forks source link

realtek-poe: De-mistify the "unknown" bug #1

Closed mrnuke closed 2 years ago

mrnuke commented 2 years ago

Off-by-one error caused the status to be reported as UFO instead of "Requesting Power".

General feeling on the OpenWRT forum about this change is positive.

mrnuke commented 2 years ago

@Hurricos, any chance we could set the repo for "Rebase and Merge" by default, instead of "Create a merge commit" ?

Hurricos commented 2 years ago

Awaiting f12e9dbbcff95ec699cdb1e05f6c579992ee826a as a separate PR (very soon!)

Hurricos commented 2 years ago

Not intentionally closed, looks like. Merging this will thankfully only add the two meaningful commits.

Hurricos commented 2 years ago

... though @mrnuke -- please correct me if I am wrong and this closure was intentional.

mrnuke commented 2 years ago

This closure was accidental. OOPS!

Hurricos commented 2 years ago

Merged. Thanks!

mrnuke commented 2 years ago

Apparently gut push origin :some-branch also closes the associated PRs