failed to compile gperftools with "-march=armv8-a+crc"

[GoogleCodeExporter]

What steps will reproduce the problem?
1. tar -zxf gperftools-2.4.tar.gz & cd gperftools-2.4
2. ./configure --host=armv7a-cros-linux-gnueabi CFLAGS="-march=armv8-a+crc 
-mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard" 
CXXFLAGS="-march=armv8-a+crc -mtune=cortex-a57.cortex-a53 
-mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard"
3. make

What is the expected output? What do you see instead?
libtool: compile:  armv7a-cros-linux-gnueabi-g++ -DHAVE_CONFIG_H -I. -I./src 
-I./src -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare 
-fno-builtin-malloc -fno-builtin-free -fno-builtin-realloc -fno-builtin-calloc 
-fno-builtin-cfree -fno-builtin-memalign -fno-builtin-posix_memalign 
-fno-builtin-valloc -fno-builtin-pvalloc -Wno-unused-result -march=armv8-a+crc 
-mtune=cortex-a57.cortex-a53 -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -MT 
src/base/spinlock.lo -MD -MP -MF src/base/.deps/spinlock.Tpo -c 
src/base/spinlock.cc  -fPIC -DPIC -o src/base/.libs/spinlock.o
In file included from src/base/spinlock.cc:39:0:
./src/base/cycleclock.h:167:2: error: #error You need to define CycleTimer for 
your O/S and CPU
 #error You need to define CycleTimer for your O/S and CPU
  ^
./src/base/cycleclock.h: In static member function 'static int64 
CycleClock::Now()':
./src/base/cycleclock.h:169:3: warning: no return statement in function 
returning non-void [-Wreturn-type]
   }
   ^
Makefile:3995: recipe for target 'src/base/spinlock.lo' failed
make: *** [src/base/spinlock.lo] Error 1

Please provide any additional information below.
"ARMv8-A" is not in the supporting list in 
src/base/arm_instruction_set_select.h, hence when we compile gperftools with 
"-march=armv8-a+crc", this error occurs.
I have attached a patch for fixing this issue, please help me review it, thanks.

Original issue reported on code.google.com by milton.c...@gmail.com on 14 May 2015 at 11:41

Attachments:

• 0001-Add-ARMv8-A-to-the-supporting-list-of-ARM-architectu.patch

[GoogleCodeExporter]

It looks like you're building for 32-bit arm8 right ?

Patch looks good. I'll apply it next Saturday.

Original comment by alkondratenko on 17 May 2015 at 6:49

[GoogleCodeExporter]

Hi alkondratenko, 
   Yes, we build this for 32-bit ARMv8-a platform.
   Thanks for reviewing.

Original comment by milton.c...@gmail.com on 18 May 2015 at 6:30

[GoogleCodeExporter]

Applied. Thanks.

Original comment by alkondratenko on 23 May 2015 at 7:53

• Changed state: Fixed