search

HuskyLens / HUSKYLENSArduino

74 stars 49 forks source link

HUSKYLENS.h contains reference to SoftwareSerial.h that won't run on all boards #5

Open jstanle1 opened 4 years ago

jstanle1 commented 4 years ago

The SoftwareSerial library won't build or run on a lot of boards (eg., Adafruit ItsyBitsy M0 Express). Including SoftwareSerial.h in HUSKYLENS.h breaks the HuskyLens library for those boards.

I think it would be better to remove SoftwareSerial.h from the library header and include it directly in the example code, possibly with a comment that it should be removed or commented out if it doesn't fit a given board (I just use Serial1 for UART, or remove it entirely for use with I2C).

Robert-Proaps commented 2 years ago

It appears that the library does not function without it.

h26k2 commented 1 year ago

It appears that the library does not function without it.

Yes, you are right as per my knowledge. I guess that it only functions on AVR Boards like { Arduino UNO, MEGA etc }