HusseinSafwan02 / pe

0 stars 0 forks source link

Event Start Time can be after End Time #5

Open HusseinSafwan02 opened 6 months ago

HusseinSafwan02 commented 6 months ago

Currently, can event can be scheduled such that its start time is after its end time. There is no validation of the input start and end times of an event.

Steps to reproduce:

  1. Input the command add_schedule title/Meeting d/CS2103T start/2024-04-14 21:00 end/2024-04-13 22:00

Expected result: The event should not be schedulable.

Actual Result: Such an event is scheduled, refer to events 3 and 4.

image.png

nus-pe-script commented 6 months ago

Team's Response

We reject this bug. The reasons are as follows:

Team chose [response.Rejected]

Reason for disagreement: image.png As mentioned here, (screenshotted from the forum post itself) unsuitable values which give more freedom to the user are not necessarily incorrect, unless they cause the application to misbehave. A start time that is later than an end time can be easily entered due to negligence/by a new user who is not familiar with the application. Handling such errors are not extreme user behaviour but rather very plausible user behaviour and therefore this should be handled.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** Having a start time that is after the end time of an event renders the event and the entire functionality moot, hence it is of high severity.