search

Husseinhj / RateLimiting.NET

Rate Limiting (debounce, throttle) for C# Portable Class Library
22 stars 5 forks source link

.net core compatibility? #1

Open jerudamaja opened 5 years ago

jerudamaja commented 5 years ago

This project is tagged as dotnet-core, but doesn't seem to be compatible. When I add the package to my .NET core project, i'm getting warnings that the 4.6.1 framework is loaded. Can you add .NET core support and/or update the project to prevent any confusion?

I'm happy to contribute if you don't have the time.

Thanks! Jeru

Husseinhj commented 5 years ago

Hi @jerudamaja. sorry for delay Fill free and request PR to improve this.

jerudamaja commented 5 years ago

Hi Hussein!

I've forked your project and committed changes into a new fork. I've submitted a PR to update your project with the changes. Please review and let me know if I can help out in any other way.

Thanks!

On Fri, Sep 27, 2019 at 3:44 PM Hussein Habibi Juybari < notifications@github.com> wrote:

Hi @jerudamaja https://github.com/jerudamaja. sorry for delay Fill free and request PR to improve this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Husseinhj/RateLimiting.NET/issues/1?email_source=notifications&email_token=AMQTZS7LDZZDSZNACZ3LBLLQLZPALA5CNFSM4IR3YJ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7Z5EJA#issuecomment-536072740, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQTZS5SJHRG4BBXVYVVYPDQLZPALANCNFSM4IR3YJ7Q .

Husseinhj commented 5 years ago

I appreciated. I will review and merge your PR if it was ready to merge.