search

Hutchy68 / Purge

MediaWiki Purge Extension
GNU General Public License v2.0
8 stars 7 forks source link

Rename Purge Extension Element #30

Open Hutchy68 opened 3 years ago

Hutchy68 commented 3 years ago

In the past week it was discovered that Semantic MediaWiki is stepping on the code of the Purge extension. Purge has been using the element #ca-purge with the word "Purge" in the link in page actions (edit, history, move, etc.) no matter what skin the user is using.

If SMW is installed and the Purge extension is installed, SMW has a page refresh function in the page actions. Unfortunately, SMW attaches itself to the same element #ca-purge and overwrites the word "Purge" with the word "Refresh" while dropping JS on top of Purge's JS. In other words, SMW completely disables the Purge extension from being used. I did look and at least SMW has a graceful backup to execute a no JS purge of the page cache with the action=purge link.

Proposing: Change element to #ca-purge-ext

Question: Should we change the text from "Purge" to "Page Cache Purge" or "Purge Cache" or something besides just "Purge"

samwilson commented 3 years ago

Does it need to use an ID? Could it just be .ext-puge-link or something? If it's and ID then I agree it should contain ext-purge or similar.

As for the text, I've changed it on a few of my wikis to "Refresh" (shorter and users said it made more sense).

Also, there's a similar feature in Cargo, where it's called #ca-cargo-purge and "Purge cache".

Hutchy68 commented 3 years ago

Well following output of all items in actions and menu etc should be an id. Wording can be thought about some more. Could even do something like “Latest version” or “Empty cache” or “Refresh page” or just leave it Purge.

samwilson commented 3 years ago

Good point. In that case, #ca-purge-ext sounds good.