search

Hutchy68 / pivot

A MediaWiki mobile skin which "Pivots" seamlessly to any size display.
https://pivot.wikiproject.net
BSD 2-Clause "Simplified" License
37 stars 18 forks source link

Incompatible with MW 1.38 - White screen #114

Open designnerd opened 2 years ago

designnerd commented 2 years ago

Setup

Issue

Causes white screen, failure of anything to load. Sites previously using the skin are removing assuming the skin is unmaintained (which is odd because 1.38 just came out and the current MW LTS is still supported).

Hutchy68 commented 2 years ago

It probably is, sorry, I just don’t have the time to keep up with mw core changes, nor do I agree with some of the directions and choices. Mustache? Really!

If the core devs object was to make extension and skin devs developing free extensions and skins harder to maintain by keeping up with the speed of deprecation of classes and methods, they succeeded.

jdlrobson commented 2 years ago

@Hutchy68 hi there! As a core developer, our intention was not making these skins harder to maintain but easier (quite the opposite actually!) and we are here to support you if needed.

Use of Mustache is purely optional (you could use Twig or anything else if you wanted to) and existing code should still work with minor modifications.

I'm making a patch as we speak and hope that after seeing it you'll reconsider maintaining it!

BrainwreckedTech commented 2 years ago

I can attest that this fix does indeed work. It would be super if this PR was approved to at least extend pivot into the 1.38 release. (Pending that, one can clone the 114 branch of the @jdlrobson fork.)

What a day to sit down and decide to script the MediaWiki upgrade process.

designnerd commented 2 years ago

No worries, thanks for the time and work you've given this great skin @Hutchy68, it has been much appreciated over the years! 🍺🍺🍺

Thanks also for the patch @jdlrobson (and for confirming it works @BrainwreckedTech). We'll get to appreciate it a bit longer before making a switch. 🍺

kghbln commented 2 years ago

@Hutchy68 I guess it is time to un-grump yourself in the light of this new context and pulls provided by @jdlrobson Please let us out of our misery. Much appreciated and thanks a ton in advance. :)

jdlrobson commented 2 years ago

Hey @Hutchy68 another option, if you are interested is that Wikimedia could share the maintenance burden with you. You could transfer this repository to the @wikimedia Github - you'd still have merge rights there and make all the decisions around the skin, but we'd be able to patch Pivot when necessary automatically. We do this for a host of other skins : https://github.com/wikimedia/?q=skins&type=all&language=&sort=

designnerd commented 2 years ago

That would be amazing for users, and hugely appreciated because we love the skin so much!

Hutchy68 commented 1 year ago

@jdlrobson I am archiving the Pivot skin so it can be moved to Wikimedia GitHub or whatever would be best. Jamie arrived Foreground too. My long term plan was to integrate Zurb Foundation 6 at some point. Thanks for taking care of this.