search

Hutchy68 / pivot

A MediaWiki mobile skin which "Pivots" seamlessly to any size display.
https://pivot.wikiproject.net
BSD 2-Clause "Simplified" License
37 stars 18 forks source link

[bug][feature]Font-Awesome fixed and IE9 removed #52

Closed Tealk closed 6 years ago

Tealk commented 6 years ago

PR Submission:

All PR's welcome, even those without an Issue

Additional Information Below

Hutchy68 commented 6 years ago

Merged into develop, thanks!

kmeyn commented 6 years ago

Hi

I did the updates but i still cannot get fontawesome to work unfortunately. It appears it is when swapping out the skin.json lines it breaks but of course that might be related to something else entirely.

Tealk commented 6 years ago

@knutmeyn If you want, I can take a look at it.

kmeyn commented 6 years ago

Thanks Tealk, I'd appreciate that but the server is behind a firewall still.
Could the issue somehow be related to the server setup?

The impression is that, when/if doing changes stepwise, the fontawesome files still does not appear to be loaded. But that's just my 2cents :)

Tealk commented 6 years ago

it's very hard to say anything about when you can't see it I'd have to take a look at it with the deverlopment tool

Hutchy68 commented 6 years ago

Some might be my fault, I just updated the README.md. How are you installing the develop branch version? Since this PR is merged, let's take this conversation back to #47 or #53