search

Hutchy68 / pivot

A MediaWiki mobile skin which "Pivots" seamlessly to any size display.
https://pivot.wikiproject.net
BSD 2-Clause "Simplified" License
37 stars 18 forks source link

Branch Develop is Broken #53

Closed Hutchy68 closed 4 years ago

Hutchy68 commented 6 years ago

Setup

Issue

@Tealk

develop branch is now completely broken with commit #52

image

Haven't looked to it in depth yet, but there is a thrown js error early on. Need to back up and look at

skin.json calls "assets/stylesheets/font-awesome.min.css", missing min.css file in assets. Should just be font-awesome.css.

You have...

$out->addHeadItem('font', '<link rel="preload" href="/skins/pivot/assets/fonts/fontawesome-
webfont.woff2?v=4.7.0" as="font" type="font/woff2" crossorigin="anonymous" />');

You are calling an href with a hard set link. What about those who use w/ or whatever/ directory to install MediaWiki.

Viewport was eliminated. Breaking mobile view now.

Tealk commented 6 years ago

develop branch is now completely broken with commit #52

I don't know why there's a problem I use this branch atm without a problem.

skin.json calls "assets/stylesheets/font-awesome.min.css", missing min.css file in assets. Should just be font-awesome.css.

I forgot to upload font-awesome.min.css

You have... $out->addHeadItem('font', ''); You are calling an href with a hard set link. What about those who use w/ or whatever/ directory to install MediaWiki.

the path is relative to the directory. It can't cause any problems

https://github.com/Tealk/pivot/tree/font-awesome_css this version is currently running error-free for me

Hutchy68 commented 6 years ago

I don't know why there's a problem I use this branch atm without a problem.

skin.json calls "assets/stylesheets/font-awesome.min.css", missing min.css file in assets. Should just be font-awesome.css.

skin.json missing resource, breaks everything, so yes the file you forgot to upload is necessary to keep things from breaking. It looks like your version is just a minified version of font-awesome.css. I just pushed back a few things to fix. You can PR the ...min.css back and remove the old font-awesome.css file, but will have to tweak the skin.json file again. Missing the left-canvas in fontawesome.css too.

the path is relative to the directory. It can't cause any problems

It can and it did. href="/skins... would look for domainname.com/skins/.... href="/w/skins... looks in the domainname.com/w/skins/... Yes, your call is relative, but relative to the domain. Not the true path of the domain if MW is installed in a directory not the root. 

href="'.$wgLocalStylePath.'/pivot

$wgLocalStylePath will automatically set the first of the relative path /w/skins or /skins or /wiki/skins or even /wiki/w/skins if someone placed a MediaWiki instance in a directory called wiki and still added a w directory in that. Could also use $wgStylePath which is the same as $wgLocalStylePath, "{$wgScriptPath}/skins" See, https://www.mediawiki.org/wiki/Manual:$wgLocalStylePath

My only goal was to get develop working quickly if anyone wants to use or test it.

Tealk commented 6 years ago

Missing the left-canvas in fontawesome.css too.

which left-canvas?

have add {$wgScriptPath} to Pivot.skin.php

Hutchy68 commented 6 years ago

Pull down the branch changes. Some I already made.

Hutchy68 commented 6 years ago

This branch is now fixed and I am going to release it after I finish here and as soon as I update the CHANGELOG.md file and set a version. I made some changes and pushed a new README.md.

Changes in README.md was updating all the Features List and settings, adding and removing some. Need to document this on the live site too. Next couple of big changes on the PR #52 were updating all of Foundation's js to v5.5.3 and pulling in all their changes to their branch of Foundation 5. There were some improvements to address warnings of deprecation of in code. My developer console thanked me :wink: I called the version v5.5.3master just to denote the change.

Also, I added preload of Font Awesome as a feature. Another warning in develop console, preloading the font but not using it early. I also took these other things into consideration when adding it as a feature: