search

Hutchy68 / pivot

A MediaWiki mobile skin which "Pivots" seamlessly to any size display.
https://pivot.wikiproject.net
BSD 2-Clause "Simplified" License
37 stars 18 forks source link

Personal section on the right no longer working #59

Closed kghbln closed 6 years ago

kghbln commented 6 years ago

Setup

Issue

After updating to v2.0.0 clicking on the user icon on the upper right to get the personal menu on the right no longer works. It does not move in. Console does not show issues.

See the demo wiki.

Hutchy68 commented 6 years ago

Actually, both are broken on mobile...left and right.

Can you make sure all files caches are cleared, js really important.

Hutchy68 commented 6 years ago

Yep, all js is broken even actions menu. I am running 2.0.0 without the issues and cleared all cached files. Other site was not caching anything and no issues either.

kghbln commented 6 years ago

No, clearing the cache does not help at all. I switched to CACHE_NONE cleared the browser cache, disabled all related configuration settings but still I am seeing this issue.

Hutchy68 commented 6 years ago

CDN? Not all the event listeners are loading. I don't see any errors in the console, but I did change the namespace of Foundation.js to match what it is now, 5.5.3master.

image

kghbln commented 6 years ago

I do not know what to do about this.

Hutchy68 commented 6 years ago

Do you have a CDN in front of the server to deliver content. Cloudflare or something?

kghbln commented 6 years ago

Do you have a CDN in front of the server to deliver content. Cloudflare or something?

No.

Hutchy68 commented 6 years ago

I'm looking at debug=true for a comparison. It doesn't appear the js is loading at all from Foundation but there is no 404, missing or console errors being logged. Let me try this on 1.27 too. I'm testing 1.30

Hutchy68 commented 6 years ago

Are you on master or develop? Did you pull down changes?

kghbln commented 6 years ago

Are you on master or develop? Did you pull down changes?

I checked out v2.0.0 so I should be on master. I just checked out version 2.0.0 on sandbox which is running MW 1.30.0 and moreover on the same server. It is working over there so most probably the new version is not compatible with MW 1.27.x

Hutchy68 commented 6 years ago

Yep, checkout branch v1.x.x ( at least I had a fallback :wink: ) and revert the site back to v1. I need to look at why 1.27 is not allowing the js to load.

Hutchy68 commented 6 years ago

....and I just updated the release to show need 1.30 until I figure out what the heck is going on.

kghbln commented 6 years ago

Will do. Yeah, having the 1.x branch was a very good idea.

kghbln commented 6 years ago

....and I just updated the release to show need 1.30 until I figure out what the heck is going on.

I will also be curious to see which version is breaking. Perhaps it works for 1.28 or 1.29 though 1.28 is obsolete anyways.

Hutchy68 commented 6 years ago

Ok, try checking out master and pulling the changes. This commit should have fixed it 56a6ed08e79afd31b55ae78ecf159b54bdebc531 and I updated the release to point at the correct tag.

kghbln commented 6 years ago

Ok, try checking out master and pulling the changes. This commit should have fixed it 56a6ed0 and I updated the release to point at the correct tag.

Done. Cool, Pivot is back in business for MW 1.27! You can now do the 2.0.1 release. I believe changing the tag of 2.0.0 is not semver.

kghbln commented 6 years ago

You can now do the 2.0.1 release. I believe changing the tag of 2.0.0 is not semver.

Ah, already done the 2.0.0 way. I guess in future ... Anyways thanks a lot for tackling this issue!

kghbln commented 6 years ago

I am a bit confused now. When checking out v2.0.0 I should be getting https://github.com/Hutchy68/pivot/commit/15cce18901d673899fd36a15ca99bf3920a45480 as tagged but I am getting https://github.com/Hutchy68/pivot/commit/b4c88e79f30b9e9dc0ad7e10a89ccb53ecfb9368?

Hutchy68 commented 6 years ago

Normally would have but.... ugh I should have released a beta first. Pretty excited to get it out and never imagined it would Bork 1.27. A bit easier to just update the tag since it was only a few hours.

kghbln commented 6 years ago

Normally would have but.... ugh I should have released a beta first.

No worries. It is sorted out now. :)

Hutchy68 commented 6 years ago

For some reason it isn't hyperlinking like other extensions. One of mine...

image

Foreground either

image

I have noticed on GitHub repos, no hyperlinks and they are not updating. They do link and update to Phabricator commits.

kghbln commented 6 years ago

I think that extensions and skins must be in the WMF-repo to work with links.

Hutchy68 commented 6 years ago

I agree but that means it must be hard coded in.

kghbln commented 6 years ago

I agree but that means it must be hard coded in.

Not necessarily. When reporting an issue here GitHub detects the revision and links to it as seen in my report here: https://github.com/Hutchy68/pivot/issues/59#issue-301092971

Hutchy68 commented 6 years ago

No I mean hardcoded in MediaWiki for specialpage.php and the output of Special:Version