search

Hutchy68 / pivot

A MediaWiki mobile skin which "Pivots" seamlessly to any size display.
https://pivot.wikiproject.net
BSD 2-Clause "Simplified" License
37 stars 18 forks source link

Uncaught Errors: Module Already Implemented #75

Closed SWAIDesign closed 5 years ago

SWAIDesign commented 5 years ago

Setup

Issue

Detailed description of the issue goes here.

Sidebars not loading on fresh Wiki install: https://wiki.ftxgames.com. Consoles show the following:

Chrome: Uncaught Error: module already implemented: user.options at Object.implement (VM3943 load.php:19) at Main_Page:119 at Array.RLQ.push (VM3943 load.php:42) at VM3943 load.php:42 at VM3943 load.php:42 implement @ VM3943 load.php:19 (anonymous) @ Main_Page:119 RLQ.push @ VM3943 load.php:42 (anonymous) @ VM3943 load.php:42 (anonymous) @ VM3943 load.php:42 load.php?debug=false&lang=en&modules=skins.pivot.js&only=scripts&skin=pivot:1 Uncaught ReferenceError: jQuery is not defined at load.php?debug=false&lang=en&modules=skins.pivot.js&only=scripts&skin=pivot:1 at load.php?debug=false&lang=en&modules=skins.pivot.js&only=scripts&skin=pivot:1 (anonymous) @ load.php?debug=false&lang=en&modules=skins.pivot.js&only=scripts&skin=pivot:1 (anonymous) @ load.php?debug=false&lang=en&modules=skins.pivot.js&only=scripts&skin=pivot:1 load.php?debug=false&lang=en&modules=jquery%2Csite|jquery.accessKeyLabel%2CcheckboxShiftClick%2Cclient%2CgetAttrs%2ChighlightText%2Csuggestions|mediawiki.RegExp%2CString%2CTitle%2Capi%2Cbase%2Ccldr%2CjqueryMsg%2Clanguage%2Cnotify%2CsearchSuggest%2Cstorage%2Cuser%2Cutil|mediawiki.action.view.rightClickEdit|mediawiki.libs.pluralruleparser|mediawiki.page.ready%2Cstartup|mediawiki.page.watch.ajax|user.defaults&skin=pivot&version=18u7pfi:141 JQMIGRATE: Migrate is installed with logging active, version 3.0.1 Main_Page:1 GET https://wiki.ftxgames.com/index.php/Main_Page 500 (Internal Server Error)

Firefox: `Error: module already implemented: user.tokens load.php:19:292 implement https://wiki.ftxgames.com/load.php:19:292

https://wiki.ftxgames.com/index.php/Main_Page:111:1501 RLQ.push https://wiki.ftxgames.com/load.php:42:630 https://wiki.ftxgames.com/load.php:42:686 https://wiki.ftxgames.com/load.php:24:378 ReferenceError: jQuery is not defined[Learn More] load.php:1:100 https://wiki.ftxgames.com/load.php:1:100 https://wiki.ftxgames.com/load.php:1:2 JQMIGRATE: Migrate is installed with logging active, version 3.0.1` I'm at a loss after trying re-installs and working on my server to check settings.
Hutchy68 commented 5 years ago

Please don’t use 1.32 it was just released. The skin will need an update which will probably cause a version bump in pivot.

SWAIDesign commented 5 years ago

Alright! Thanks. Got ahead of myself with this first time install of MediaWiki. Works fine now.

kghbln commented 5 years ago

Just yesterday I realized that Pivot is not working for 1.32 but @SWAIDesign was faster to report. Thanks a lot. I updated mediawiki.org and pivot.wikiproject.net to provide an info about this.

I guess this issue should remain open until a fix was provided and released. Once this is done I will update the docu again.

@Hutchy68 is still on MW 1.27. I will upgrade soon to MW 1.31.

r2d02 commented 5 years ago

I'm also kindly requesting to re-open this issue.

MW 1.32 wasn't "just released" as noted by @Hutchy68, it has been released 3 months ago and is currently the latest stable release of MW. So this should be treated as an issue.

Thank you @kghbln for updating mediawiki.org and pivot.wikiproject.net.

Hutchy68 commented 5 years ago

The 1.32.0 stable release was released on 10 January 2019.

r2d02 commented 5 years ago

MW 1.32 wasn't "just released" as noted by @Hutchy68, it has been released 3 months ago and is currently the latest stable release of MW. So this should be treated as an issue.

Obivously it has been "branched from git master" on 2018-10-16 , the release was indeed on January 10th 2019.

Hutchy68 commented 5 years ago

That might have been alpha then beta then rc. Stable means ready for production use is what I’m getting at. Besides 1.32 is a STS so, while I will look into what is going on, it will not be a rush.

latindancer commented 5 years ago

Hello,

Can you please let me know what the status of this issue is for MW 1.32?

Thanks

kghbln commented 5 years ago

https://github.com/Hutchy68/pivot/issues/75#issuecomment-456741960

@Hutchy68 is now on MW 1.31. Here Pivot is till working.

latindancer commented 5 years ago

Any update on this issue? Are you going to have it fix for MW 1.32?

Hutchy68 commented 5 years ago

See #78. Still working on a fix as to why js is executing before jQuery is loaded.

latindancer commented 5 years ago

@Hutchy68 Thanks for the update :)

Hutchy68 commented 5 years ago

Fixed in Release v2.1.0