Hutchy68 / pivot

A MediaWiki mobile skin which "Pivots" seamlessly to any size display.
https://pivot.wikiproject.net
BSD 2-Clause "Simplified" License
37 stars 18 forks source link

Login and personal_urls #99

Closed paulb-smartit closed 4 years ago

paulb-smartit commented 4 years ago

Setup

Issue

Detailed description of the issue goes here.

The extension MW-OAuth2Client places a link to the OAuth Login page into the personal_urls array. This link doesn't appear in the pivot page anywhere to be used to login. The only personal_urls item displayed is Login.

$personal_urls['anon_oauth_login']['href']

This maybe an issue with the extension, but any guidance you can give on this would be appreciated.

Hutchy68 commented 4 years ago

Yes, I suppose there was a flaw in my logic of creating only a login method that was MW centric. So try this...

Change... Pivot.skin.php @ lines 132-147 from

                    <aside class="right-off-canvas-menu">
                      <ul class="off-canvas-list">
                    <?php if ($wgUser->isLoggedIn()): ?>
                        <li id="personal-tools"><label>Personal</label></li>
                        <?php foreach ($this->getPersonalTools() as $key => $item) { echo $this->makeListItem($key, $item); } ?>
                            <?php else: ?>
                                <?php if (isset($this->data['personal_urls']['anonlogin'])): ?>
                                    <li><a href="<?php echo $this->data['personal_urls']['anonlogin']['href']; ?>"><?php echo wfMessage( 'login' )->text() ?></a></li>
                                <?php elseif (isset($this->data['personal_urls']['login'])): ?>
                                    <li><a href="<?php echo htmlspecialchars($this->data['personal_urls']['login']['href']); ?>"><?php echo wfMessage( 'login' )->text() ?></a></li>
                                        <?php else: ?>
                                            <li><?php echo Linker::link(Title::newFromText('Special:UserLogin'), wfMessage( 'login' )->text()); ?></li>
                                <?php endif; ?>
                            <?php endif; ?>
                      </ul>
                    </aside>
                    <aside class="right-off-canvas-menu">
                      <ul class="off-canvas-list">
                        <li id="personal-tools"><label>Personal</label></li>
                        <?php foreach ($this->getPersonalTools() as $key => $item) { echo $this->makeListItem($key, $item); } ?>
                      </ul>
                    </aside>

If you can wait, I will push a patch. I think there can be some more improvements and the title Personal under personal-tools should be a message. It probably should change from Login/Create Account to Personal Tools when logged in. Any other ideas or suggestions on this appreciated from anyone.

Hutchy68 commented 4 years ago

Use git to fetch and then checkout branch login-improvements

Comparison of https://github.com/Hutchy68/pivot/compare/develop...login-improvements which includes a fix for Issue #98

Please comment on the fixes so I can prep an update and new release. Thanks!

Hutchy68 commented 4 years ago

Merged into develop branch. No replies on issue, so closing. Thanks for reporting.