search

HuwCampbell / grenade

Deep Learning in Haskell
BSD 2-Clause "Simplified" License
1.45k stars 84 forks source link

Adjust bounds #107

Closed sorki closed 11 months ago

sorki commented 11 months ago

Mainly the text one in example is causing trouble.

Tested using GHC 9.4.

Also a couple of README, typo fixes.

erikd commented 11 months ago

Looks good. Thanks.

tomjaguarpaw commented 4 months ago

Seems like these revisions should be made on Hackage too. Without them it's impossible to depend on grenade from Hackage on modern GHCs. This came up when I was helping someone out on Discourse: https://discourse.haskell.org/t/how-to-create-quickcheck-tests-for-dependently-typed-matrix-addition-without-specifying-each-dimension-statically/9993/3

erikd commented 4 months ago

Making this build with ghc-9.8 and ghc-9.10 will require code changes and a new upload. I have the ability to merge PRs etc here on Github, but I do not have official upload rights (I however I might be able to do it as a Hackage Trustee).

HuwCampbell commented 4 months ago

Yeah as a trustee you definitely could. I can also make the changes to the metadata. The dependencies have shifted a little though, so I'll need to double check them all before hitting go.

erikd commented 4 months ago

Supporting ghc-9.8 and later will need a code update.