search

HuwCampbell / grenade

Deep Learning in Haskell
BSD 2-Clause "Simplified" License
1.45k stars 84 forks source link

GHC 8.6.3 compatibility #79

Closed claudeha closed 5 years ago

claudeha commented 5 years ago

Fixes #78.

I tested that it compiles successfully with GHCs 7.10.3, 8.0.2, 8.2.2, 8.4.4, 8.6.3, but I haven't checked that it works correctly in all those versions. Seems to work in GHC-8.6.3 at least (I get some ASCII circles with the feedforward example, and ASCII glyphs with the gan-mnist example).

HuwCampbell commented 5 years ago

Thanks for this. I'll have a look some time in the near future. In general I think it looks pretty good, but I generally prefer to not use default extensions. If it's easier to just drop 7.10 and have less CPP, I think that's a viable path as well.

erikd commented 5 years ago

This has been merged in PR #85 . Thanks @claudeha !