search

HuwCampbell / grenade

Deep Learning in Haskell
BSD 2-Clause "Simplified" License
1.45k stars 83 forks source link

Update Layer.hs #83

Closed dme2 closed 5 years ago

dme2 commented 5 years ago

Just fixed a spelling error agnotostic -> agnostic

erikd commented 5 years ago

@HuwCampbell The build failure is only happening with ghc 7.10.3 and its failing on the typelits-witnesses package. Since this package is using dependent types, its highly unlikely to be compatible across multiple GHC versions. What do you think of just dropping GHC 7.10.3 ? Probably have to do this just to support GHC 8.6 anyway.

From this it looks like if we want to support ghc 8.6, then we need to drop 7.10.

HuwCampbell commented 5 years ago

I think that's a fair call now.

On Sun, Feb 17, 2019 at 4:57 PM Erik de Castro Lopo < notifications@github.com> wrote:

@HuwCampbell https://github.com/HuwCampbell The build failure is only happening with ghc 7.10.3 and its failing on the typelits-witnesses package. Since this package is using dependent types, its highly unlikely to be compatible across multiple GHC versions. What do you think of just dropping GHC 7.10.3 ? Probably have to do this just to support GHC 8.6 anyway.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HuwCampbell/grenade/pull/83#issuecomment-464420550, or mute the thread https://github.com/notifications/unsubscribe-auth/AE9t0Q6Z5DDER1BgAk-Lzud1lsPW6pXYks5vOO8ugaJpZM4a_FAw .

erikd commented 5 years ago

Thanks @notdave22 !