search

HuwCampbell / grenade

Deep Learning in Haskell
BSD 2-Clause "Simplified" License
1.44k stars 84 forks source link

bring to lts-5.5 #99

Closed Nolrai closed 4 years ago

Nolrai commented 4 years ago

Oh, sorry, I didn't mean to push it to your project! Not entirely sure how that happened.

On Sat, Mar 28, 2020 at 5:48 PM Erik de Castro Lopo < notifications@github.com> wrote:

@erikd requested changes on this pull request.

Thanks for the stack lts-5.5 update, but the second bit, switching travis from cabal to stack will not be accepted.

@HuwCampbell https://github.com/HuwCampbell the original author and owner of this project and I (occassional contributor) both pefer cabal to stack

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HuwCampbell/grenade/pull/99#pullrequestreview-383362391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJONI3BEX5OVYOTJT37MFTRJ2LHBANCNFSM4LVYWZEA .

erikd commented 4 years ago

You submitted a PR, and then pushed more commits to the same branch. All commits to the same branch will considered as part of the same PR.

Nolrai commented 4 years ago

Ah. Must have forgotten the pr submitted to you. I later submitted a pr to my fork with the same branch so sorry about that!

On Sat, Mar 28, 2020 at 7:37 PM Erik de Castro Lopo < notifications@github.com> wrote:

You submitted a PR, and then pushed more commits to the same branch. All commits to the same branch will considered as part of the same PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HuwCampbell/grenade/pull/99#issuecomment-605549451, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJONIYCNEKN3PGNPEYBBZTRJ2X53ANCNFSM4LVYWZEA .

erikd commented 4 years ago

Would you like me to cheery pick the just the stack.yaml changes?

Nolrai commented 4 years ago

That's probably the best idea.

On Sat, Mar 28, 2020, 9:45 PM Erik de Castro Lopo notifications@github.com wrote:

Would you like me to cheery pick the just the stack.yaml changes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HuwCampbell/grenade/pull/99#issuecomment-605558361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJONI5YAQN36CAY6DQYWL3RJ3G6FANCNFSM4LVYWZEA .

erikd commented 4 years ago

Closing in favor of https://github.com/HuwCampbell/grenade/pull/100