search

Huy-Ngo / skin-crawler

A web crawler for crawling dermoscopic images of skin cancer.
MIT License
4 stars 2 forks source link

Finalize backend #32

Closed dinhanhx closed 3 years ago

dinhanhx commented 3 years ago

⠀

dinhanhx commented 3 years ago

@Huy-Ngo so I have tried to merge branches at local machines. I ran the server stuff. It worked for all kaggle, isic, yandex, wikimedia. This comment is meant to tell you that when branches merged into main, things doesn't break.

kaggle

image

isic

image

yandex

image

wikimedia

image

Huy-Ngo commented 3 years ago

@dinhanhx You didn't pull from Quang's branch. The yandex module is missing here.

dinhanhx commented 3 years ago

@dinhanhx You didn't pull from Quang's branch. The yandex module is missing here.

fixed Yandex module is already in branch main

Huy-Ngo commented 3 years ago

It makes it hard for local testing. The next time you do this (as it, doing any kind of project in collaboration with someone else) make sure your new branch has all the feature needed.

dinhanhx commented 3 years ago

It makes it hard for local testing. The next time you do this make sure your new branch has all the feature needed.

Okay. I agree it was bad move.

Huy-Ngo commented 3 years ago

Please add data.json to .gitignore.

dinhanhx commented 3 years ago

Please add data.json to .gitignore.

Added to be ignored.

dinhanhx commented 3 years ago

Your code look good. It just lacks functionality, which I added, so please also review that.

I have pulled it down and ran flask stuff. It works.