HvyIndustries / crane

PHP Intellisense/code-completion for VS Code
https://hvy.io/crane
Other
240 stars 25 forks source link

Implement the php-reflection library #207

Open nevadascout opened 7 years ago

nevadascout commented 7 years ago

Replace the php-parser library with the newly created php-reflection library.

It may be easier to rewrite the plugin from scratch than to try to pick everything apart ???

ichiriac commented 7 years ago

Todo list on server side :

Todolist from the client :

ichiriac commented 7 years ago

Found from vscode code https://code.visualstudio.com/Docs/editor/debugging#_multitarget-debugging the way to start debug with breakpoints on server & client from a single editor instance.

Now for running the extension, must start the Launch Client/Server target.

ichiriac commented 7 years ago

In order make everything run :

cd client
ln -s ../server src-server
cd src-server
npm run watch

On windows use this : http://superuser.com/questions/1020821/how-to-create-a-symbolic-link-on-windows-10

By opening the client folder from vscode a new folder src-server was created. You can edit sources and run the Launch Client/Server according.

To add a break point, I was unable to do it from TS files, must go on server/...js file and add a breakpoint, it will work but without the TS source - maybe a workaround exists


Libraries development :

Clone the php-repositiory, run npm install and next npm link Do the same with php-reflection, run npm install and next npm link Go to your php-reflection folder, and run npm link php-parser

Into the server folder, run npm link php-parser and npm link php-reflection Go to client folder, and add references to external libraries : ln -s ../server/node_modules/php-reflection and ln -s ../server/node_modules/php-parser

When you make changes into these folders they will point to their repositories, so you will be able to commit them directly