search

Hwww23 / pe

0 stars 0 forks source link

Possible feature flaw in logic of having duplicate tasks #2

Open Hwww23 opened 4 months ago

Hwww23 commented 4 months ago

Input: addtask n/Implement find for task d/Remind task to be done p/low

Output:

image.png

It might be helpful to check for duplicate/very similar task in the tasklist to help users see more clearly the accurate number of task they have, this would also help them in terms of marking of task since they might forget or miss out on marking its duplicate as complete.

soc-pe-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate task checking is not case-sensitive

As mentioned in the title, the checking for duplicate tasks is not case-sensitive. This may result in actual duplicate tasks when it is actually just a difference in case sensitivity.

To reproduce:

  1. addtask n/task1 d/something p/1 by/18-02-2022 12:00
  2. addtask n/Task1 d/something p/1 by/18-02-2022 12:00

image.png

I suggest that the duplicate check for task names be made case-sensitive and/or be extended to the deadline of the task as well (a task is duplicate if and only if the name and the deadline of both tasks are equal)

[original: nus-cs2103-AY2324S2/pe-interim#407] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We intended for two tasks to be considered different if the casing for the task names is different. The fact that both commands succeed is intended, therefore this is certainly not a functionality bug.

We claim that this is also not a feature flaw, because the meaning of a task might change simply by changing the casing in the task name. For example, "Write email to teammates" and "Write email to TEAMMATES" are different tasks. The latter likely refers to the task of sending an email to the TEAMMATES dev team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The task being flagged as a duplicate of the one I mentioned is a case sensitivity issue. However, what I have mentioned is an exact copy where case sensitivity isn't the issue.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Having exact duplicate tasks can be a feature flaw or possibly a functionality bug
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]