search

HxCKDMS / HxCEnchants

Adds many new enchantments to minecraft.
GNU General Public License v3.0
1 stars 0 forks source link

Crash for HxC Enchant 1.6 #10

Closed ReportBot9009 closed 9 years ago

ReportBot9009 commented 9 years ago

I'm getting a nullpointer with the 1.6 update: http://pastebin.com/LwGN7Bmx

Also, the Penetrate and Piercing Enchants are not working correctly. I do the same amount of damage to armored targets at all levels of the enchant as well as the same damage without it.

Take care

DrZed commented 9 years ago

Yeah I gotta fix that wait a moment... Also Those enchants I don't think are broken but they're hard to test so let me do some testing

ReportBot9009 commented 9 years ago

Ya, I understand they are hard to test. My modded game has roguelike dungeons which has armored mob spawners, so it's easy for me to test it in my game. The mob spawners range from chain to diamond armor. Also, is one for the bow and arrow?

DrZed commented 9 years ago

Piercing is sword Penetrating is arrow (or backwards IDK)

ReportBot9009 commented 9 years ago

Haha! Well, I've tried both on both and it doesn't change, so I'm not sure either XD

DrZed commented 9 years ago

WOW I FAILED BIG TIME

DrZed commented 9 years ago

if (Config.enchPiercingEnable) { PiercingLevel = EnchantmentHelper.getEnchantmentLevel(Enchants.Piercing.effectId, item); if (PiercingLevel > 0) Victim.attackEntityFrom(new DamageSource("Piercing").setDamageBypassesArmor(), Config.PiercingDamage); } yet config is never set so the value is 0

ReportBot9009 commented 9 years ago

Oh dang! Whoops! Nice catch :)

DrZed commented 9 years ago

Here ya go or wait 10 minutes for Curse http://puu.sh/iq7y0.jar

ReportBot9009 commented 9 years ago

Awesome! Thank you so much :)